I have more than a few button-up shirts in my closet and strong opinions about what makes a good one. For the 2024 edition of this guide, I tested 21 button-up shirts.